icecoder/ICEcoder

Close tab logic needs improving

Closed this issue · 4 comments

If you open 5 tabs and have the last tab (5) as the current tab. Click the close link for tab 3 (without selecting the tab, just click close on tab 3), tab 3 is closed, but you now have tab 2 selected.

(Note: it appears to do this after a very brief pause and to do with ICEcoder.overCloseLink being undefined).

Closed in d884c2e

Done but switchTab seems necessary to handle changing of icon in tabs and possibly more, reopening for investigation and fixing.

I'm sure ICEcoder also used to slide the tabs across to fill gap when you closed a tab but this no longer happens. To look into and ensure it happens.

renameTab was used to set the icon and also fixed things so the selectedTab remains the same after closing a tab to the left of it.

As for animated close tabs, we could do this in the future, but it's not a real problem, so closing now main fixes done.