icecube/photospline

HIERARCH and case sensitivity

Closed this issue · 1 comments

While HIERARCH keywords are case-sensitive the ESO convention, cfitsio went ahead and started uppercasing key names in fits_write_key() around about 3.38, causing the write_fits_spline and fits_mem_spline tests to fail. The least bad solution is probably to raise an error on splinetable::write_key() if the key contains lower case characters, since we can't guarantee those are preserved.

Ugh, that's. . . highly unhelpful of cfitsio. I'd have more sympathy for its devs breaking the non-standard usage of HIERARCH for long keywords if they weren't the ones who had inflicted it on us in the first place. I agree that disallowing lower case letters in keys is probably the most sane thing to do.