blocks: Error loading model minecraft:soul_fire
iceiix opened this issue · 1 comments
iceiix commented
Connecting to a 1.7.10 server unexpectedly logs:
[model/mod.rs:226][ERROR] Error missing block state for minecraft:soul_fire
[model/mod.rs:196][ERROR] Error loading model minecraft:soul_fire
even though this is a very new block not present in this version. It was added in #474 for 1.16.1/2+, but mistakingly applied to the pre-flattening versions as well.
Need to add data None
to these new block definitions so they are not picked up pre-1.13. This includes at least SoulFire
and SoulSoil
. The offsets |protocol_version| { if protocol_version >= 735
code only applies post-flattening; data
is used pre-flattening (posted a longer explanation here: #453 (reply in thread))