SaveActiveSlot() saving wrong value
Vrumfondel opened this issue · 5 comments
Moving this to a own function is a good idea, but current implementation is wrong:
Doing a slotindex++ in SaveActiveSlot() is only working for RevE, since _tagslotIndexOffset is 1.
For RevG the offset is 0, so there is 1 added when saving, but not substracted when restoring --> Marked slot is one index to high ....
I will fix this in my next PR
looking forward to the PR
Nice, looks like we are almost there. The resizing of controls inside tabs still needs to be done in utils tab. There is a IDENTIFY button and textbox.. I have no idea why its in this tab. Its a pure REVG function however.
Agreed: The function should be only visible for RevG, like mbfo32 only works on RevErebooted.
Why in Utils - well, there was space for it without re-arranging too much.
But it easily can be moved to "Operation" and show the result in the Output window.
Yeah, move to operations tag and show result in output window, and become disabled on RevE rebooted firmware..
So I moved it and resized the utils controls. Looks better.
Now there is some translations missing because of new GUI