icerpc/slicec

Renamed `returnValue` to `returnType`

Closed this issue · 2 comments

When an operation returns a single type (instead of a tuple), we implicitly assign that return parameter the name returnValue.
But this name doesn't fit with our terminology. A "return value" is the actual value returned by an implementation.
This field should be renamed to something more correct like returnType.

I think returnValue is the correct name for this single return parameter.

If you have a method with a single (input) parameter, would you name this parameter "arg[ument]" or "parameter"?

I would go with arg and returnValue.

If you have a method with a single (input) parameter, would you name this parameter

After thinking about it, I'm honestly not sure, both names are too bad for me to contemplate.
But if you prefer returnValue that's fine with me!