icgc-argo/program-service

Add INTL as an allowed country code

Closed this issue · 3 comments

rosibaj commented

As you mentioned it, I think MUTO-INTL will better reflect the international nature of our project (cases coming from Africa, Asia, Europe, North and South America)

For projects from multiple countries we need to extend the allowed value on country code to also accept INTL

INTL needs to be added as a country code
so -INTL is allowed

Location:
https://github.com/icgc-argo/program-service/blob/develop/src/main/java/org/icgc/argo/program_service/validation/ProgramShortNameValidator.java

Expected Outcome

I can create a program with a shortname followed by -INTL as a country code. For testing, i will use ROSE-INTL.

image

blabadi commented

should we also validate that 1 country programs shouldn't end with INTL since it's now allowed ?

rosibaj commented

hmm i would say not a needed validation. Since only the DCC is making these then we can audit which ones we add this to

rosibaj commented

Tested on qa Sept 29,2020

  • was able to successfully add a program with -INTL as the country code
  • was able to update the same program successfully.
  • was not able to add any other 4 letter codes

image

@Buwujiu looks great!! thank so much.