icons-pack/react-simple-icons

Components and README not UpperCamelCase

Hahlh opened this issue · 3 comments

Hahlh commented

Good day!

First of all, thank you for maintaining this package!

The README states:
image

I am a little confused, as I wouldn't consider capitalizing only the first letter to be UpperCamelCase.
Should the description be changed or the component names be corrected?

Two sources about UpperCamelCase:
https://wiki.c2.com/?UpperCamelCase
https://en.wikipedia.org/wiki/Camel_case

@Hahlh thanks for your issue, the names of the react components are wrongly named, we should rename them to this MyComponent.

If you already have a utility to rename all the components you would be happy to merge your pr, since there are components that are named this way in the data of simple-icons

Can I instead make a pr on the simple-icons pr asking them to merge it to make all the names camelcase?

Hahlh commented

Hey there @wootsbot! 🙂

I actually just saw this as it was closed, please excuse getting back to you so late. I assume the issue is settled?