idkjs/resattributes

first line is wrapped in double quotes

despairblue opened this issue · 2 comments

Running npx resattributes produces this:

"# Tell github that .re and .rei files are Reason, sometimes recognized as C/C++"
*.re linguist-language=Reason 
*.rei linguist-language=Reason
*.res linguist-language=ReScript
*.resi linguist-language=ReScript

instead of

# Tell github that .re and .rei files are Reason, sometimes recognized as C/C++
*.re linguist-language=Reason 
*.rei linguist-language=Reason
*.res linguist-language=ReScript
*.resi linguist-language=ReScript

Somehow the index.sh is escaped in the tarball that was released:

#!/usr/bin/env sh
echo "\"# Tell github that .re and .rei files are Reason, sometimes recognized as C/C++"\" >> ${PWD}/.gitattributes
echo "*.re linguist-language=Reason " >> ${PWD}/.gitattributes
echo "*.rei linguist-language=Reason" >> ${PWD}/.gitattributes
echo "*.res linguist-language=ReScript" >> ${PWD}/.gitattributes
echo "*.resi linguist-language=ReScript" >> ${PWD}/.gitattributes

I tried replicating this using yarn pack but could not.

I think we need another release after feb1cdd 🤔

Thanks for making this :)

idkjs commented

hey! Cool. Right, a release. I guess you saw I fixed it. Let me see if I remember how to release. BRB

idkjs commented

Maybe you could try it again and let me. I cant seem to get the release to work right. It works on my local machine. Maybe the minor release isnt registering for some reason.

I got the package to update on npm and I am still getting this when using from npm.

"# Tell github that .re and .rei files are Reason, sometimes recognized as C/C++"
*.re linguist-language=Reason 
*.rei linguist-language=Reason
*.res linguist-language=ReScript
*.resi linguist-language=ReScript

While running it on my machine I get the desired effect:

# Tell github that .re and .rei files are Reason, sometimes recognized as C/C++
*.re linguist-language=Reason
*.rei linguist-language=Reason
*.res linguist-language=ReScript
*.resi linguist-language=ReScript

You have any idea what this is about? Let me know, and I will fix it. Thanks for the feedback.