ielizaga/gpcheckintegrity

Function get_* shadow a global variable db

Closed this issue · 1 comments

The functions get_databases(), get_tables(), get_tables_in_schema() and database_schema_exists() shadow the global variable db. This causes no errors but it is a bad practice and those local variables should be renamed.

The function database_schema_exists() does not close the connection to the DB. This issue would be a good chance to fix that.