igaster/laravel-theme

Allowed to keep the view paths added at runtime after setting theme

videni opened this issue · 0 comments

foreach ($this->laravelViewsPath as $path) {

May be we should use the config('view.paths'); to get views paths instead of setting it to the laravelViewsPath, so It's possible to get user's configured paths at runtime.

Add a view path before setting theme like following

        app('view.finder')->addLocation($sourcePath);

Then try to set current theme by

Themes::set('one_theme')

now the above path lost. instead of using the addLocation method, we can add new path to view.paths config ,

app('config')->push('view.paths', $sourcePath);

clearly say we want to keep the path like statically configured view paths after setting theme.