Problems with record autoformatting
istocniks opened this issue · 12 comments
IDEA 14.1.1, Erlang 0.5.11
Let's assume I have an empty record and my cared is placed inside it's braces:
That's what happen if I hit enter, an extra closing brace is created:
Similar thing happens if the record is not empty:
My code style config:
Just so as you know - the buggy behavior was caused by an unmatched left curly brace in code above.
Check out the latest build: https://github.com/ignatov/intellij-erlang/releases/
Not really sure which unmatched left curly brace you are referring to...
I checked the latest build, an extra brace doesn't get created any more, thanks!
But caret still doesn't get indented automatically, looks like you didn't address this bug :(
Please, share an example of incorrect caret indentation - I may have missed some cases.
Thanks for the fast response!
Here it is, the caret should be automatically indented here, but it's not.
Where does it go instead? What's your tab/indent/continuation indent size?
And also, why would you want it to go there? The formatter will add indentation for each record field assignment anyway.
Take a look at the screenshots, it goes to the same level as the record definition itself.
Here are my settings:
Oh, I misread the "caret should be automatically indented here" as if the screenshot would show the correct indentation =)
Thanks!
Thanks again for addressing this, unfortunately I found new bugs after the latest changes :(
- Closing curly brace doesn't appear/disappear automatically when I add/remove opening curly brace if a record is in function body, but it works if a record is part of function argument list. Same for parentheses and brackets.
- Continuation indent doesn't work and it's config value has no effect, again same for parentheses and brackets.
- Caret does not indent when I hit enter inside empty brackets
Could you create separate issues for these, please?
Once again, thank you very much for reporting issues. It's really unfortunate to have new bugs appearing after fixing the old ones, but we're increasing test coverage, so it'll eventually get better =)