use a semantic better close icon?
Closed this issue · 11 comments
Hi @ignism !
I'm using your theme for the last month and it was great.
But i don't understand why you are using the github icon as a close icon, is just don't feel semantically right click in a cat to close things.
What do you think?
Hi man!
I am not sure what you mean. You mean the X in tabs and stuff? I am using that X because its the same as in OS X. But maybe I am wrong and you mean something else, or this doesn't work for you. If so, could you please send a little screenshot of the issue?
Hi @ignism :) ! Yes i mean the X in tabs and stuff. Take a look this screenshot in linux:
But for example the One Dark theme has a different icon more appropiate for a close button:
How it looks in your OS X?
And excuse my bad English!
Oh, I am glad you brought this up. I have no access to linux, so I can't test it there. It should look like the screenshot in the README, I will definitely fix this this weekend.
I'll also try to see if I can put it on the right side for linux and windows, and keep it on the left for OS X.
Thanks!! :) glad to help!! I enjoy using your theme!
it's only there when you hover your mouse I guess?
yes
Hey @tinchoz49, I've uploaded a patch. Would you be so kind to check it out and report back? If you could also provide a screenshot of how it looks.
is working like a charm 👍 !
thanks! for the future here you have a linux tester if you need it!
do i close the issue?
Thanks for your help, yeah I'll close it.
This was my problem too! Glad it's fixed, this is definitely my favorite Atom theme! 👍