igrigorik/videospeed

The latest update broke the display.

FailSafeNow opened this issue · 0 comments

Lately, when I've been changing the speed of videos on YouTube, I only sometimes get the speed display in the top left corner. Sometimes it doesn't appear at all. And I think I see the reason why. I have a video open right now where I'm having the problem. The extension adds the vsc-show class to the vsc-controller, but it doesn't remove the vsc-hidden class. So your style that tells vsc-hidden not to appear (display: none) just stays in place.

In order to get the display to appear, I had to override the style on my computer using Stylebot:

.vsc-controller.vsc-nosource.vcs-show {
display: unset;
}

In fact, even when I remove the vsc-hidden class, the display doesn't appear when the vcs-show class is added. I'm guessing there used to be a style in there that changed its css display property, that somehow got left out of this last release.