iina/iina

Touch Bar updated when not visible

Opened this issue · 0 comments

low-batt commented

System and IINA version:

  • macOS 14.4.1
  • IINA 1.3.4

Expected behavior:
IINA follows the best practices in the Energy Efficiency Guide for Mac Apps. In the case at hand:

  • Eliminate drawing when your app or its content is not visible, such as when your app's content is obscured by other views, clipped, or offscreen.

Actual behavior:
IINA consumes CPU updating the Touch Bar when it has not been configured to show application controls.

Steps to reproduce:
Using a MacBook Pro that has a Touch Bar and is not in closed clamshell mode follow these instructions:

  • Open System Settings
  • Click on Keyboard
  • Click on the Touch Bar Settings… button
  • A popup displays Touch Bar settings
  • Select F1, F2, etc. Keys for the Touch Bar shows setting
  • Confirm the popup looks like the screenshot below
  • Click Done
  • Start IINA playing a video
  • Open Terminal
  • Paste sample IINA into Terminal and press return
  • The sample will take a while to collect and process
  • Once the sample appears it will show time spent in Touch Bar specific drawing methods such as TouchBarPlaySliderCell.drawBar

touchbar-settings

How often does this happen?
Every time.