iina/iina

RTL language causes clipped aspect ratio button

Opened this issue · 5 comments

System and IINA version:

  • macOS 13.6.3
  • IINA 1.3.4 + PR #4922

Expected behavior:
Names of buttons are normally not clipped.

Actual behavior:
Currently IINA does not support any right to left languages. However PR #4922 enables Hebrew. If you build IINA with that pull request and set Hebrew as the language and open the quick setting panel the Default ("ברירת מחדל") button under Aspect ratio is clipped:
clipped

This problem was reported by @ShlomoCode in issue #4776. As that issue reports quite a few RTL related problems I have created this issue to focus just on this particular problem.

Steps to reproduce:

  • Pull PR #4864

  • Open the IINA project in Xcode

  • Under the Product menu open the Scheme menu and select Edit Scheme…

  • Click on the Options tab

  • Scroll down to the App Language setting

  • In the pull down select Hebrew

  • Start IINA running under Xcode

  • Start playing a video

  • Press ⇧⌘V to show the video panel

  • Notice the Default ("ברירת מחדל") button is clipped

  • MPV does not have this problem.

mpv does not support localization.

How often does this happen?
Every time.

With the proposed fix in the PR:
fixed

looks good

uiryuu commented

To my understanding, this is not an RTL specific issue right? The PR looks good tho.

Yes. This one has more to do with the length of the text.

Should close as resolved