iina/iina

RTL language causes misalignment of equalizer label

low-batt opened this issue · 1 comments

low-batt commented

System and IINA version:

  • macOS 13.6.3
  • IINA 1.3.4 + PR #4922

Expected behavior:
The text fields under the sliders in the Equalizer section on the AUDIO tab of the quick settings panel are properly aligned with slider they are intended to label.

Actual behavior:
Currently IINA does not support any right to left languages. However PR #4922 enables Hebrew. If you build IINA with that pull request and set Hebrew as the language then show the audio panel the 31.25 label is severely miss-aligned:
equalizer

Steps to reproduce:

  • Pull PR #4922

  • Open the IINA project in Xcode

  • Under the Product menu open the Scheme menu and select Edit Scheme…

  • Click on the Options tab

  • Scroll down to the App Language setting

  • In the pull down select Hebrew

  • Start IINA running under Xcode

  • Start playing a video

  • Press ⇧⌘A to show the audio panel

  • Notice the 31.25 label under the sliders in the Equalizer section is miss-aligned

  • MPV does not have this problem.

mpv does not support localization.

How often does this happen?
Every time.

ShlomoCode commented

Should close as resolved