RTL causes icons to overlap with the text in the Quick Settings tabs
Opened this issue · 5 comments
System and IINA version:
- macOS 14.4.1
- IINA 1.3.4 + PR #4922
Expected behavior:
The icons do not overlap with the label text in right-to-left languages such as Arabic and Hebrew.
Actual behavior:
Currently IINA does not support any right-to-left languages. However PR #4922 allows Hebrew. If you build IINA with this pull request and set Hebrew as the language then the tabs labels in IINA quick settings overlap the labels. (see screenshots below)
Screenshots:
Steps to reproduce:
- Open the IINA project in Xcode
- Under the
Productmenu open the Scheme menu and selectEdit Scheme… - Click on the
Optionstab - Scroll down to the
App Languagesetting - In the pull down select
Right-to-Left Pseudolanguagenear the end of the list - Start IINA running under Xcode
- Open Quick Settings
- Notice that the icons overlap the text
However, only two of the 3 tabs seem to overlap. It might help with the investigation.
- MPV does not have this problem.
mpv does not support localization.
How often does this happen?
Every time.
I will look into this.
These are buttons that have an image and a title. The buttons are configured with Image Hugs Title. The problem is that the images are not centered:
In addition the alignment is not uniform between the images. This is why when reversed with an RTL language the SUBTITLES button has a larger gap between the image and the title compared to the other tabs.
One solution would be to create a second set of images for when the title is left of the image.
One of the IINA developers who are able to create images will need to fix this issue.
ping @lhc70000
It looks exactly like the screenshots above
Can you upload a screenshot with Hebrew?