ijpatricio/nova-larastan-tool

Status while it's running?

Closed this issue · 9 comments

ragingdave commented

I'm not necessarily even saying that it would need to give a progress bar (though would be nice), can it at least have some indication that pressing the button did something?

ijpatricio commented

Nice found! Will do it! As you said, at least a spinner 👍

ijpatricio commented

Hey @ragingdave

I just put a spinner, indicating that the ajax request is performing.

image

Can you please update and check if everything alright?

Thanks!

  • 👍1
ragingdave commented

Just tested it and it for sure works, other than some parsing issues that are unrelated to this.

  • 👍1
ijpatricio commented

Thanks!

I didn't get it. Can you elaborate on that parsing issues?

ragingdave commented

I'm not even sure if this can be handled by this, but basically if it hits an exception and can't complete the scan then it fails. Maybe if it can't parse the result it should just return whatever it has to help diagnose the issue, rather than having to rerun the artisan code:analyse command

ijpatricio commented

Thanks. Will dig deeper.
From what you say, it's a matter of outputting the exception message and trace (same info as you get from running in console).

Is this accurate?

ragingdave commented
ijpatricio commented

I'll try to open a new issue, based on this.

(My first steps on open source 😃 )

ijpatricio commented

Opened #2 (comment)
I mentioned you, but I guess it didn't work as you're still not participating in that issue.

Can you go there and say something, so I can close this one and keep issues organized?

Thanks!