ikostrikov/pytorch-a2c-ppo-acktr-gail

should h5py be listed as dependency?

Opened this issue · 0 comments

Hi
I am wondering if h5py should be listed in requirements,txt?
As we can see, h5py is used in a2c_ppo_acktr/algo/gail.py as a must. But when I follow the installation step from README.md, it seems that h5py will not be installed automatically. So should h5py be listed as dependency?
Beyond that, if it is better to explicitly point out PyTorch and baselines as dependencies in requirements.txt?
image