Airports code review
Opened this issue · 0 comments
mandyWW commented
Ilia, this code is excellent, beautifully laid out and great attention to detail (JSDoc, use of const, naming of tests etc).
A few comments below:
- For the next project (Scooters), worth separating out class and test files to separate dirs
- Airport.test.js - I would have separate tests for testing error conditions and normal flows ie. split the constructor test into 2 and name each one appropriately. Same comment for other tests.
- Crew.test.js - wrong name in describe - same issue in other tests
Otherwise, great! I didn't clone to view the coverage report but think from looking at the raw HTML you have 100%? If so, amazing!