iliyaZelenko/tiptap-vuetify

Image support?

assoft opened this issue · 18 comments

Are you considering supporting the image/embeds extension? When can you think about it?

Hey, @assoft.

First of all, thanks for giving me a star, this is what motivates me to work with the project.

If you need it, then I will start working on it today, I think it will take a few days at most, I hope it will not be long for you?

I want this project to become popular, so I need to satisfy the desires of users.

Do you have any ideas about uploading images? It is very interesting to me.

Hi @iliyaZelenko,

First of all, I want to thank you for starting this project.

I think you've completed a serious shortcoming to Vuetify.

API is perhaps the best way to upload images

No, absolutely no rush for me

I wish you good work.

i'm sorry i'm not good enough to speak english.

Example On Nuxt.js

Thank you @iliyaZelenko

I'd definitely be interested in this too!

What ideas were you looking for @iliyaZelenko ?

Thanks for the support guys. I work on it and I have a lot of plans. I will try to release the update as soon as I can.

This has been a little delayed since I am working in the company now and I am changing the project structure cardinally so that it is easier for further development and flexible for user expansion. You will have the functionality to easily add your own buttons (not necessarily buttons) and change existing ones.

I plan to add the extension for loading images into a separate package in order to make the editor modular. I will create the same separate package for the extension with which you can add emoticons.

Maybe I will also have to create a separate package for each package so that these extensions can be used in tiptap without the need for vuetify.

For the images extension, I plan to make a system of plugins, with the help of which you can choose hosting for downloading or your own REST API.

What ideas were you looking for @iliyaZelenko ?

These can be any of your ideas. For example, how do I make this as flexible as possible for users.

I also added the ability to choose where to display the buttons: in the toolbar or in the tooltip.

No rush from me either.

The separate packages sounds like a really good idea, then we can just pull in what we need.

I'm not sure what the best practice for this is, but maybe let the user pass an async callback which lets them do the API query themselves?

Really liking your plans for the future!

Hi, I also wait image support!
Please consider about AWS S3 upload :-) and Drag and drop

IT would be good, hope we will get it soon

Added in 2.6.0.

image

Use Image extension for this. Example here.

Note: since the original extension works through base64, then I had to do it too. That is, the pictures are not uploaded to the server, but stored in the editor’s content. In the future I plan to make a real upload, I will have to create my own image extension for tiptap. Also I will try to fix resize issue in my extension.

I will try to fix resize issue in my extension.

Hello Ilia, did you manage to fix it?

@nibytes not yet. I will let you know when will be ready.

@iliyaZelenko Do you think you will be completing this image upload soon? It's a much awaited feature.

Hi! I also do not have enough load images.
You did a great job! Thank you very much!

Does Image Uploader support file types like .jpeg or .png ?
Also it would be great to add Image size limit feature i.e 5 mb max file size. Does the extension currently support this?

@ksdhir the default uploadof pictures works through bass64 (.jpeg and .png must be supported), this can be seen by src of image. This editor gives you the flexibility to upload pictures to your backend server. You must write the download code yourself. In the end, you will need to transfer the link to the downloaded image for this editor to use it. More info here.

@avgeeklucky Sorry! I am using custom image upload components in my nuxt project, everything seem to work fine until I try to use it with store using this.$store. I wonder are there anyway I could access store in the custom component? I'm really appreciate your answer!

This is a great feature indeed!

Just curious was there any fix for resizing?
@iliyaZelenko thank you for such a great project