Some patterns displayed in wrong language
iluwatar opened this issue · 6 comments
iluwatar commented
In issue #18 we fixed the patterns showing up more than once, but another problem came up. Some patterns now show in the wrong language e.g. Singleton displayed in Chinese. At the moment we support showing only English versions and the other ones can be filtered out.
JackieNim commented
Look into these PR's for the fix
This should go in first -> iluwatar/java-design-patterns#1750
#24
iluwatar commented
@JackieNim the PR you mentioned seems to be closed 🤷🏻♂️
JackieNim commented
@JackieNim the PR you mentioned seems to be closed 🤷🏻♂️
I created iluwatar/java-design-patterns#1752 but seems like he doesnt want to review it again so 🤷
iluwatar commented
No worries @JackieNim, I think we can reopen it
iluwatar commented