image-rs/deflate-rs

Readme claims no unsafe but there is one

nico-abram opened this issue · 1 comments

nico-abram commented

deflate-rs/src/output_writer.rs

Line 101 in 2385f2a

unsafe {

I don't personally think this is a big deal and I think the readme is probably just outdated, but imo the readme should be corrected. Would something like "There is a single instance of unsafe behind a feature flag that proved to measurably affect performance" be ok?

oyvindln commented

Oh yeah, that's just an oversight. Will just change it to use a safe lookup, compiler may optimize it anyway. Thought I had done a search for unsafe. The function is only used RLE mode, which has to explicitly chosen when compressing so it's not often used.