immerrr/lua-mode

upcoming rx.el version is not compatible

kidd opened this issue · 5 comments

kidd commented

Just wanted to note that new rx.el (from emacs git) has gone through some refactors and rx-constituyents and rx-parent changed in some ways and there should be some changes made to this mode.

From first inspection I see rx-constituyents is still there for backward compatibility. rx-parent isn't there anymore though.

Thanks for the update/heads up. I believe it's a duplicate of #150 (that is should be fixed in #152 and already released on melpa by now). Please, give it a try.

I find rx-form still call once in lua-mode.el

(rx-form `(seq symbol-start ,form symbol-end) rx-parent))

That branch is only executed when the new way of customizing regexps is not available (see fboundp check above).

Awesome, fixed! Thanks!!

my bad. the repo I used is a mirror of melpa, It's not updated yet.

add: There is another message in Emacs 27, "Package cl is depercated".
I think this need change in the future.

kidd commented

oh! sorry I totally missed #150 and #152. Awesome!

I'll try it asap. Closing