Improve ts types

Question

Improve ts types

Closed this issue a year ago · 5 comments

It looks like some types are not resolved on the fastify.Sentry instance as they would when using the Sentry instance.

Answer 1 · 2022-12-05T11:32:24.000Z

Maybe we should re-export all the Sentry types 🤔

Answer 2 · 2022-12-06T08:18:26.000Z

@mdoria12 wdyt?

Answer 3 · 2022-12-23T09:59:58.000Z

I've tried by adding this at the end of the index.d.ts file:
export * from '@sentry/types';

and this solve my use case of using the Severity enum.
But it seems that we should not use this approach anymore, because the enum is exported as a type and deprecated by Sentry itself, so i think we can keep the current types as is and close this issue for now.

@dnlup wdyt?

Answer 4 · 2022-12-23T11:05:41.000Z

I am thinking if we could have another use case similar to yours that could benefit of exporting all the types 🤔

Answer 5 · 2023-04-21T10:10:18.000Z

Maybe we can consider a rewrite in TS in a new release 🤔