CSV file with empty cells is getting parsed
thisismayuresh opened this issue · 1 comments
thisismayuresh commented
Describe the bug
When parsing and importing CSV file with empty cell values, it's getting imported and showing in import widget. The empty lines looks like this,
,,,,,,,,,,,,,
,,,,,,,,,,,,,
,,,,,,,,,,,,,
,,,,,,,,,,,,,
,,,,,,,,,,,,,
,,,,,,,,,,,,,
,,,,,,,,,,,,,
,,,,,,,,,,,,,
,,,,,,,,,,,,,
,,,,,,,,,,,,,
,,,,,,,,,,,,,
,,,,,,,,,,,,,
,,,,,,,,,,,,,
To Reproduce
Steps to reproduce the behaviour:
- Create Import and Add columns
- Try importing CSV file with empty field values. (As described above)
- Upload, Do Mapping and check in review step, the empty rows will be shown.
Expected behaviour
Empty rows should not be imported and shown in review step.
Screenshots
Additional context
May we can work here
https://github.com/implerhq/impler.io/blob/next/apps/api/src/app/review/usecases/do-review/base-review.usecase.ts#L327
And here,
https://github.com/implerhq/impler.io/blob/next/apps/api/src/app/review/usecases/do-review/base-review.usecase.ts#L472
thisismayuresh commented