impress-org/give-google-analytics

fix: ensure that only donations that come through forms send data to Google Analytics

Closed this issue · 0 comments

samsmith89 commented

Bug Report

User Story

As a site admin, I want only donations that come through forms to send a beacon to Google Analytics so that manual donations aren't sent as well.

Current Behavior

Whenever a manual donation is created there is a note in the donation details stating that a beacon was sent to Google Analytics.

Expected Behavior

Only donations that are submitted through the forms send data to Google Analytics.

Or an option to include these donations from the addon settings.

Bug Type

  • I am not sure whether this functionality ever worked as expected.

Steps to Reproduce

  1. Create a manual donation in the backend of Give.
  2. View the notes section of the donation details
  3. See that there is a note that information was sent to Google Analytics

Visuals

Here's a screencast detailing the issue:
https://screencast-o-matic.com/watch/cqVerirWs4

Related

https://secure.helpscout.net/conversation/745853836/31979/

Acceptance Criteria

  • donations that are created in the backend of Give don't send information to Google Analytics

Environment

Operating System
  • Platform: Mac OS X
Browser
  • Name: Chrome
WordPress System Info ### WordPress Environment ###

Home URL: https://give.gsamsmith.com
Site URL: https://give.gsamsmith.com
WP Version: 5.0.2
WP Multisite: –
WP Memory Limit: 256 MB
WP Debug Mode: –
WP Cron: ✔
Language: en_US
Permalink Structure: /%year%/%monthnum%/%day%/%postname%/
Show on Front: posts
Table Prefix Length: 4b8_
Table Prefix Length: 4
Table Prefix Status: Acceptable
Admin AJAX: Accessible
Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, request-pending, request-confirmed, request-failed, request-completed, in-progress, failed, wc-pending, wc-processing, wc-on-hold, wc-completed, wc-cancelled, wc-refunded, wc-failed, refunded, revoked, cancelled, abandoned, processing, preapproval, recurring, give_subscription

Server Environment

Hosting Provider: DBH: localhost, SRV: give.gsamsmith.com
TLS Connection: Connection uses TLS 1.2
TLS Connection: Probably Okay
Server Info: Apache
PHP Version: 7.0.33
PHP Post Max Size: 64 MB
PHP Time Limit: 30
PHP Max Input Vars: 1000
PHP Max Upload Size: 64 MB
cURL Version: 7.62.0, OpenSSL/1.0.2q
SUHOSIN Installed: –
MySQL Version: 5.6.41
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ✔
DOMDocument: ✔
gzip: ✔
GD Graphics Library: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔

Give Configuration

Give Version: 2.3.1
Give Cache: Enabled
Database Updates: All DB Updates Completed.
Give Cache: Enabled
Give Cache: ✔New Donation✔Donation Receipt❌New Offline Donation❌Offline Donation Instructions✔New User Registration✔User Registration Information✔Donor Note✔Email access❌Renewal Receipt Email❌Renewal Receipt Email❌Subscription Cancelled Email❌Subscription Cancelled Email❌Subscription Completed Email✔Subscription Reminder Email✔Subscriptions Email Access
Upgraded From: 2.2.4
Test Mode: Enabled
Currency Code: USD
Currency Position: Before
Decimal Separator: .
Thousands Separator: ,
Success Page: https://give.gsamsmith.com/donation-confirmation/
Failure Page: https://give.gsamsmith.com/donation-failed/
Donation History Page: https://give.gsamsmith.com/donation-history/
Give Forms Slug: /donations/
Enabled Payment Gateways: Test Donation, AmeriCloud Payments - Credit Card, PayPal Standard, Stripe - Credit Card
Default Payment Gateway: AmeriCloud Payments - Credit Card
PayPal IPN Verification: Disabled
PayPal IPN Notifications: IPN received for #784 ( 19K29889DJ726282J ) on 01/03/2019 at 11:41. Status N/A
Donor Email Access: Enabled

Active Give Add-ons

Give - Google Analytics Donation Tracking: ❌ Unlicensed – by GiveWP – 1.2.1
Give - Manual Donations: ❌ Unlicensed – by GiveWP – 1.4.2
Give - PayPal Pro Gateway: ❌ Unlicensed – by GiveWP – 1.2.1
Give - Recurring Donations: ❌ Unlicensed – by GiveWP – 1.8.3
Give - Stripe Gateway: ❌ Unlicensed – by GiveWP – 2.1.2
Give - Tributes: ❌ Unlicensed – by GiveWP – 1.5.2
Give - Zapier: ✔ Licensed – by WordImpress – 1.2.1
Give Error Kill: ❌ Unlicensed – by WordImpress – 1.0

Other Active Plugins

All-in-One WP Migration: by ServMask – 6.81
Email Cop: by Ashfame – 0.1.1
Give - AmeriCloud Payments: by AmeriCloud Solutions, Inc. – 1.3.1
My Custom Functions: by Space X-Chimp – 4.31
Query Monitor: by John Blackbourn & contributors – 3.2.2
Transients Manager: by Pippin Williamson – 1.7.5
WooCommerce: by Automattic – 3.5.2
WooCommerce Blocks: by Automattic – 1.2.0
WordPress Importer: by wordpressdotorg – 0.6.4
WP Rollback: by Impress.org – 1.6

Inactive Plugins

Akismet Anti-Spam: by Automattic – 4.1
Contact Form 7: by Takayuki Miyoshi – 5.1
Debug Bar: by wordpressdotorg – 1.0
Give - 2Checkout Gateway: by WordImpress – 1.1.2
Give - Authorize.net Gateway: by WordImpress – 1.4.3
Give - AWeber: by WordImpress – 1.0.3
Give - Braintree Gateway: by WordImpress – 1.2.2
Give - CCAvenue Gateway: by WordImpress – 1.0.2
Give - Constant Contact: by WordImpress – 1.2.1
Give - ConvertKit: by WordImpress – 1.0.2
Give - CSV Toolbox: by WordImpress – 1.0
Give - Currency Switcher: by GiveWP – 1.3.1
Give - Donation Upsells for WooCommerce: by GiveWP – 1.1.0
Give - Dwolla Gateway: by WordImpress – 1.1.2
Give - Email Reports: by WordImpress – 1.1.2
Give - Fee Recovery: by GiveWP – 1.7.2
Give - Form Field Manager: by GiveWP – 1.4.1
Give - Gift Aid: by GiveWP – 1.2.0
Give - GoCardless Gateway: by WordImpress – 1.2.1
Give - iATS Payment Solutions: by GiveWP – 1.0.4
Give - MailChimp: by GiveWP – 1.4.3
Give - Mollie Gateway: by WordImpress – 1.1.2
Give - PayFast Payment Gateway: by WordImpress – 1.0.2
Give - Paymill Gateway: by WordImpress – 1.0.2
Give - Paytm Gateway: by WordImpress – 1.0
Give - PayUmoney: by GiveWP – 1.0.3
Give - PDF Receipts: by GiveWP – 2.3.2
Give - Per Form Gateways: by WordImpress – 1.0.1
Give - Razorpay: by WordImpress – 1.2.0
Give - Sofort Payment Gateway: by WordImpress, CoachBirgit – 1.0
Gutenberg: by Gutenberg Team – 4.7.0
Head and Footer Scripts Inserter: by Space X-Chimp – 4.33
Invisible reCaptcha: by Mihai Chelaru – 1.2.1

Active MU Plugins

Endurance PHP Edge: by Mike Hansen – 0.2
SSO: by Garth Mortensen, Mike Hansen – 0.3

Theme

Name: Twenty Seventeen
Version: 1.7
Author URL: https://wordpress.org/
Child Theme: No – If you're modifying Give on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme