impress-org/give-google-analytics

fix: only show a form view event for fields actually viewed

Benunc opened this issue · 1 comments

Bug Report

User Story

As a user, I want Form View events to not be logged if the button for modal or button mode is not clicked so that actual form views by the potential donor are tracked.

Current Behavior

Currently, if a form is button mode on a page, and the button is not clicked, it still registers a form view at Google. Similarly, a Modal style form grid triggers the form view event. This makes it impossible to reliably track actual form view events.

Expected Behavior

I expect it to only fire a form view when a form is viewed.

Bug Type

  • This bug describes functionality that never worked as expected.

Steps to Reproduce

  1. Install, activate and configure Google Analytics.
  2. Place a button mode form on a page
  3. View the page in a logged-out browser.
  4. GO to real-time events in Google analytics dashboard. It will have recorded a Form View.

Related

https://secure.helpscout.net/conversation/1104727180/59156/

Acceptance Criteria

  • form view events are only triggered by the form actually being displayed to a human.