improper/lando-magento2-template

Replace built-in Magento downloader with improper/mage2me

tylers-username opened this issue · 4 comments

tylers-username commented

Is your feature request related to a problem? Please describe.
Yes, the Lando template shouldn't have to know how to fetch Magento, only run it.

Describe the solution you'd like
Install mage2me and allow that service to be responsible for understanding Magento 2 download requirements

Describe alternatives you've considered
Have you seen this repo? Gross.

Additional context

https://github.com/improper/mage2me

From my comment in the thread:

  • GitHub token authentication & validation prior to download
  • Magento public/private key authentication & validation prior to download
  • Magento Edition and Version Validation with clear error messages
    • You can specify Commerce (enterprise) or Open Source edition
    • When the version is specified (2.2, 2.3.x, 2.4-develop) mage2me will validate that the version exists for the Magento edition that you requested prior to launching composer create-project.
  • Nice, clear error messages each step of the way
  • Nicely compiled executable allowing it to be standalone and installed globally
  • Should be fully compatible with Windows, OSX and Linux
  • Improved directory validation
tylers-username commented

@azmeehan - I've refactored the Magento downloader to a stand-alone service. I'd love it if you could preview it and give me feedback:

tylers-username commented

Some nice features:

  • GitHub token authentication & validation prior to download
  • Magento public/private key authentication & validation prior to download
  • Nice, clear error messages each step of the way
  • Nicely compiled executable allowing it to be standalone and installed globally
  • Should be fully compatible with Windows, OSX and Linux
  • Improved directory validation
azmeehan commented

@tylerssn Ive had some time to test this. Seems to work with the latest stable release tags like 2.3.5 or 2.3.4 but not with any of the branches. Ive tested with interactive and standalone Magento downloads but I keep getting the following error:

Could not parse version constraint 2.4.0: Invalid version string "2.4.0-develop"

Ive tried 2.3 and 2.4-develop both with the same result.

tylers-username commented

@azmeehan - this was corrected in mage2me v1.1.0. I'm not quite sure what changed between testing and now, but you were right - installing dev branches broke down.

Now, in order to install a dev branch --dev must be passed to mage2me. Also, this is only compatible with Magento Open Source Github branches & tags - it is not yet compatible with Magento 2 Commerce.

I'm going to leave this ticket open in hopes of integrating mage2me into this template once it has been battle tested.