inbo/INBOtheme

Error: object ‘inbo.lichtblauw’ is not exported by 'namespace:INBOtheme'

Closed this issue · 6 comments

Deze error krijg ik wanneer ik poog reportingGrofwild te builden in docker.
De dockerfile van deze app instaleert steeds de nieuwste versie van INBOtheme, zie deze link:

https://github.com/inbo/reporting-rshiny-grofwildjacht/blob/46fd9f15452531ec17dc73187e89d6831740c2f9/Dockerfile#L29

Ik vermoed dat in de laatste 3 maanden een aanpassing is gebeurd waardoor "inbo.lichtblauw" niet meer behoort tot de opties van INBOtheme. Klopt dit ? Zoja, hoe los ik dit op?

Het is nogal dringend !!

Blijkbaar zijn de punten in de kleurnamen vervangen door underscores, dus probeer eens met inbo_lichtblauw

@ElsLommelen dank je.
De punten in de kleuren zijn idd vervangen door een underscore.

This breaking change is mentioned in the startup message and in NEWS.md

@ThierryO @florisvdh
Would it be an idea to announce such breaking changes in INBO packages (or often used packages) the OSD nieuwsbrief?

Yesterday I got a similar question on this topic, and honestly, when I am forced to update all my packages due to an unexpected R update in a busy period, I also don't read all news items of all packages I reinstall. And though the startup message is very clear in the R console, I see now, I didn't notice it yesterday when solving this problem in a Rmd file sent by another user. When starting a new script, I'm sure one would notice the message immediately, but when rerunning an old script which has always worked fine, the message might get lost, I noticed... So a newsletter item to announce breaking changes once more, could be helpful in my opinion.

That sounds like a good idea - of course it depends for which packages you'd consider that (there's a risk of growing too large, considering the many package developments at INBO). But for updates of general-purpose packages such as INBOtheme, I believe that fits well in the 'new developments' part. For more specific/specialized stuff, such information could be spread through our useR mailing list or to a specific user group.

This breaking change is mentioned in the startup message and in NEWS.md

In the R-console yes! But I didn't notice it while building the app in Docker!!

I'm also a proponent of announcing breaking changes (like this issue and #15) in some sort of newsletter.