inbo/etnservice

Adapt list_ functions for use by OpenGPU

PietrH opened this issue · 6 comments

PietrH commented

TODO

Adapt functions:

  • list_acoustic_project_codes
  • list_acoustic_tag_ids
  • list_animal_ids
  • list_animal_project_codes
  • list_cpod_project_codes
  • list_deployment_ids
  • list_receiver_ids
  • list_scientific_names
  • list_station_names
  • list_tag_serial_numbers
  • list_values
  • list_network_project_codes
  • list_tag_ids

Adapt tests:

  • list_acoustic_project_codes
  • list_acoustic_tag_ids
  • list_animal_ids
  • list_animal_project_codes
  • list_cpod_project_codes
  • list_deployment_ids
  • list_receiver_ids
  • list_scientific_names
  • list_station_names
  • list_tag_serial_numbers
  • list_values
  • list_network_project_codes
  • list_tag_ids

Pass tests:

  • list_acoustic_project_codes
  • list_acoustic_tag_ids
  • list_animal_ids
  • list_animal_project_codes
  • list_cpod_project_codes
  • list_deployment_ids
  • list_receiver_ids
  • list_scientific_names
  • list_station_names
  • list_tag_serial_numbers
  • list_values
  • list_network_project_codes
  • list_tag_ids

Add postman tests:

  • list_acoustic_project_codes
  • list_acoustic_tag_ids
  • list_animal_ids
  • list_animal_project_codes
  • list_cpod_project_codes
  • list_deployment_ids
  • list_receiver_ids
  • list_scientific_names
  • list_station_names
  • list_tag_serial_numbers
  • list_values
  • list_network_project_codes
  • list_tag_ids

Expand postman tests with response content test:

  • list_acoustic_project_codes
  • list_acoustic_tag_ids
  • list_animal_ids
  • list_animal_project_codes
  • list_cpod_project_codes
  • list_deployment_ids
  • list_receiver_ids
  • list_scientific_names
  • list_station_names
  • list_tag_serial_numbers
  • list_values
  • list_network_project_codes
  • list_tag_ids
  • pass tests vliz rstudio
  • pass R CMD CHECK
  • check postman test results
  • export postman tests
  • commit postman tests to repo using handy tool
PietrH commented

list_values doesn't use a database connection, thus doesn't need any changes to be used over the api. I'm not sure it makes sense to provide an API version of this function.

#' List all unique values from a data.frame column
#'
#' Get a vector with all unique values found in a given column of a data.frame.
#' Concatenated values (`A,B`) in the column can be returned as single values
#' (`A` and `B`).
  • 👎1
PietrH commented

list_animal_ids() is untested in etn main

PietrH commented

Should depriciated functions be ported to the API?

Example; list_network_project_codes() and list_tag_ids() ? All in inbo/etn/etn-deprecated.R

PietrH commented

Deprecated functions are not ported to the API, list_values() will not be ported to the api.