inbo/etnservice

fix broken examples

PietrH opened this issue · 3 comments

PietrH commented

Some examples are broken because they still use the old connection argument, or refer to the con object. If they are outside dontrun{} chunks, they will block R CMD CHECK

PietrH commented

blocker for #33

PietrH commented

When running examples, I run into the following error:

Error: nanodbc/nanodbc.cpp:1118: 00000: [unixODBC]FATAL: remaining connection slots are reserved for non-replication superuser connections

It seems we have a connection leak, it's probably prudent to close connections after we are done with them if we will not be reusing them.

PietrH commented

All tests outside dontrun chunks run fine, some within these chunks might still contain references to the deprecated connection argument.

It's possible to run examples in don't run chunks using devtools::run_examples(run_dontrun = TRUE)