inconshreveable/muxado

Getting an internal error

armon opened this issue · 10 comments

armon commented

When doing session.Accept() I'm getting an unexpected "Session closed".
Doing Wait() to get more info, I see this:

Error Code: 2
Error: "Illegal frame type: 0"
Debug: []

This seems to only happen when the last stream was being used for TLS, and it occurs immediately after that stream closes.

inconshreveable commented

Any chance you can post a gist with code to reproduce?

armon commented

Got a reproducable test here: https://gist.github.com/armon/9474081

armon commented

You just need to provide some generated SSL keys for it to work (don't need to be valid)

inconshreveable commented

Awesome, I can reproduce it! Thanks so much for that. Digging into this now.

inconshreveable commented

@armon Thanks for the test case, that made it super easy to figure out what was going on.

armon commented

@inconshreveable Thanks for fixing both of these!

armon commented

@inconshreveable When I re-run the test script with the changes, I'm still getting a panic with the same error.

Here is the traceback: https://gist.github.com/armon/3d61b014af7a5f20ca34

Maybe consider re-opening?

inconshreveable commented

Hrm. I can run the test script without issue locally without an issue and I can verify that I pushed all of the changes. Can you verify that you're running against the new code?

Kill your muxado code locally so that go is forced to get it again?

rm -rf $GOPATH/src/github.com/inconshreveable/muxado
go get -v github.com/inconshreveable/muxado

go clean might help as well.

If it's still happening and you're sure you have the new code, we'll reopen and try to find another way to reproduce the issue

armon commented

@inconshreveable Looks like this was a derp on my part. Working fine now! Thanks!

inconshreveable commented

Awesome, glad it's working!