yaz_xml_get_prop(), xml_get.c
textbrowser opened this issue · 2 comments
textbrowser commented
The variable argument list ap is not closed properly.
va_end(ap); // Please add.
return (const char *) attr->name;
va_end(ap); // Please add.
return (const char *) attr->children->content;
MikeTaylor commented
Thanks for spotting all these -- it's good to get some code review.
We'd find it more convenient if you could wrap them all up in a single pull-request, though.
adamdickmeiss commented
I think we manage. Thanks.