remove IPPort.WithIP, IPPort.WithPort?

Question

remove IPPort.WithIP, IPPort.WithPort?

josharian opened this issue 3 years ago · 3 comments

These were useful as shims while updating Tailscale to use the opaque IPPort. They're a bit ugly, though. Should we remove them prior to upstreaming?

Answer 1 · 2021-07-04T17:25:43.000Z

Did you just replace those calls with netaddr.IPPortFrom()?

Answer 2 · 2021-07-27T21:38:39.000Z

Did you just replace those calls with netaddr.IPPortFrom()?

I haven't done it yet. The fix would be a combination of two things. In some places, explicitly tracking an IP and a port. In others, replacing with IPPortFrom.

Answer 3 · 2021-12-01T00:42:29.000Z

Upstreaming of IPPort (as AddrPort) is complete; these got cut.