fuzz build broken

Question

fuzz build broken

josharian opened this issue 3 years ago · 4 comments

#204 says it fixes the fuzz build by removing a duplicate type detection. But on my machine, #204 breaks the fuzz build. As main at f6a6f43, I see:

$ go-fuzz-build
/Users/josh/x/netaddr/fuzz.go:133:40: undeclared name: appendMarshaler
/Users/josh/x/netaddr/fuzz.go:187:18: undeclared name: appendMarshaler
typechecking of . failed

@dsnet any idea why we're seeing opposite failures?

Answer 1 · 2021-07-21T21:17:37.000Z

Using different people's go-fuzz impls? Dmitry's vs Katie et al's?

Answer 2 · 2021-07-21T21:18:19.000Z

Oh, I tried it with the dev.fuzz branch (i.e., Katie's).

Answer 3 · 2021-07-21T21:19:28.000Z

I didn't realize it was Dmitry's fuzzer implementation. We should probably revert my change.

OR if we think Katie's is the future, we can roll-forward to use that.

Answer 4 · 2021-07-21T21:25:49.000Z

Let's support both for the moment; it's easy. I'll send a PR.