DialProxy.DialTimeout defaults to "disabled" instead of "default value" as the doc says
geropl opened this issue · 0 comments
geropl commented
The comment reads: // If zero, a default is used.
// DialTimeout optionally specifies a dial timeout.
// If zero, a default is used.
// If negative, the timeout is disabled.
DialTimeout time.Duration
The source says: if zero, the timeout is disabled
func (dp *DialProxy) HandleConn(src net.Conn) {
ctx := context.Background()
var cancel context.CancelFunc
if dp.DialTimeout >= 0 {
ctx, cancel = context.WithTimeout(ctx, dp.dialTimeout())
}
dst, err := dp.dialContext()(ctx, "tcp", dp.Addr)