infctr/eslint-plugin-typescript-sort-keys

Consider contributing features up to typescript-eslint?

JoshuaKGoldberg opened this issue · 7 comments

JoshuaKGoldberg commented

Hi! I'm a maintainer on typescript-eslint and just stumbled onto this plugin from a feature request on the typescript-eslint member-ordering rule (typescript-eslint/typescript-eslint#4859). It looks like much of this plugin's functionality is already in member-ordering.

Is there anything in particular you'd want to be added to member-ordering that doesn't exist in it already?

infctr commented

Hey @JoshuaKGoldberg
Thanks for reaching out! There are many plugin users on npm, so I would expect all the of the options from interface and string-enum rules to be supported in member-ordering

infctr commented

I can see that requiredFirst: true is not supported in member-ordering, is it?

JoshuaKGoldberg commented

Ooh, it isn't, no. Now that I'm taking a deeper look I see the natural sorting option isn't either.

Are you up for filing an issue on typescript-eslint and/or sending a PR in? No worries if that's a sudden unexpected ask you don't have time for 😄, I can take on whatever you don't.

I'll also note our docs page isn't great right now and I plan on fixing it up soon: typescript-eslint/typescript-eslint#4861

infctr commented

@JoshuaKGoldberg Go ahead :)

  • 🚀1
zachbryant commented

Just as a user looking between these two, the reason I'm choosing eslint-plugin-typescript-sort-keys is the auto-fixer

  • 👍5
connorjs commented

Here’s the FR for auto fixer on official TS ESLint side: typescript-eslint/typescript-eslint#2296