influxdata/giraffe

Visualizations don't support fill of _time

genehynson opened this issue · 3 comments

If I set fill: ['_time'], it breaks most (if not all) visualizations. Here is an example of the line chart:

image

I pushed my changes to storybook that recreate this issue here: https://github.com/influxdata/giraffe/tree/genehynson/repo-time-bug

Also see:

I think what I'd expect to see in this situation is a bunch of lines where the start and end point of those lines are always equal - so basically a scatter plot.

This issue won't fix the underlying issue in https://github.com/influxdata/EAR/issues/2599 because the issue there is that a line is not being rendered.

So, even if Giraffe were to render dots for lines that have only data point each, and we then see a scatter plot-like visualization, that would not be what the storage trend should look like.

I would say this is an entirely separate issue, and is summarized as follows:
Giraffe line graphs do not render dots for single points of data for each line.

fill can be loosely defined as "a column that makes a group of data unique" such as defining a line in a line graph. In other words, the fill property defines the different lines in a set of data, grouping the data into different lines.

If time is used in fill this would cause the grouping to be unique by time, which makes the x-axis look very weird (you would see a bunch of vertical lines) or you would need the x-axis to be something else other than time. Generally this use case is not directly supported by Giraffe. There may be many ancillary bugs and unresolved issues when the x-axis is not time.

Since this is very unconventional, I am closing this issue.