influxdata/influxdb-client-php

DeleteService::postDelete() requires passing org and bucket explicitly

logarytm opened this issue · 2 comments

logarytm commented

This is sort-of related to #87, where I discovered that the data-deleting API presented in the README does not exist.

Steps to reproduce:
List the minimal actions needed to reproduce the behavior.

$service = $client->createService(DeleteService::class);
$predicate = new DeletePredicateRequest();
// Prepare the predicate...

// Notice I did not specify `$org` nor `$bucket`.
$service->postDelete($predicate);

Expected behavior:
Perhaps it could take the org and bucket from the Client?

Actual behavior:

In DeleteService.php line 136:

  [400] Client error: `POST http://localhost:8086/api/v2/delete` resulted in a `400 Bad Request` response:
  {"code":"invalid","message":"Please provide either orgID or org"}

Specifications:

  • Client Version: 2.1.0
  • InfluxDB Version: OSS 2.0
  • Platform: PHP 7.4
bednar commented

Hi @logarytm,

the DeleteService is autogenerated from InfluxDB's API definition so we are not able change this class.

What do you think about create a DeleteApi - wrapper around DeleteService? Is this something you might be willing to help with?

Regards

bednar commented

This issue has been closed because it has not had recent activity. Please reopen if this issue is still important to you and you have additionally information.