PHP 8 compatibility
andig opened this issue · 6 comments
Currently tied to highest 7:
"php": "^5.5 || ^7.0",
Has there been any movement on this?
The code itself appears to run fine under php 8, but the tests are more of a problem; running them on php 8 requires upgrading to phpunit 8/9, which have minimum php requirements in the 7.x range. I've got a fork with minimal changes to support that, tagged version 1.15.1.2 supports php 8.
The code itself appears to run fine under php 8, but the tests are more of a problem; running them on php 8 requires upgrading to phpunit 8/9, which have minimum php requirements in the 7.x range. I've got a fork with minimal changes to support that, tagged version 1.15.1.2 supports php 8.
Do you need any manpower or have you finished it?
Do you need any manpower or have you finished it?
It's essentially done. The only change needed by client code is updating the supported PHP versions in composer.json. The tagged version does that, plus the minimal changes to get phpunit running without errors. There's one more commit in the branch to have the tests run cleanly on phpunit 9.
Do you need any manpower or have you finished it?
It's essentially done. The only change needed by client code is updating the supported PHP versions in
composer.json. The tagged version does that, plus the minimal changes to get phpunit running without errors. There's one more commit in the branch to have the tests run cleanly on phpunit 9.
Sounds great, will you be making a PR soon?