infoportugal/wagtail-modeltranslation

Wagtail 2.11 compatibility

mariod3w opened this issue · 2 comments

I recently updated the new version of Wagtail 2.11, and I get the following error.

File "/Users/mario/Documents/GitHub/environments/ve_wagtail/lib/python3.7/importlib/__init__.py", line 127, in import_module return _bootstrap._gcd_import(name[level:], package, level) File "<frozen importlib._bootstrap>", line 1006, in _gcd_import File "<frozen importlib._bootstrap>", line 983, in _find_and_load File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked File "<frozen importlib._bootstrap>", line 677, in _load_unlocked File "<frozen importlib._bootstrap_external>", line 728, in exec_module File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed File "/Users/mario/Documents/GitHub/environments/ve_wagtail/lib/python3.7/site-packages/wagtail_modeltranslation/wagtail_hooks.py", line 29, in <module> from wagtail.wagtailcore import hooks ModuleNotFoundError: No module named 'wagtail.wagtailcore'

I think it is related to this function
from wagtail.admin.views.pages import get_valid_next_url_from_request does not exist in the new version of wagtail

Is an update planned to solve these problems?

The 4e782eb patch fixes the import error, but I have another error when trying to get a page url.

eg. from wagtail.core.models import Page; Page.objects.first().url gives:

wagtail/core/models.py in <listcomp>, line 1571: not enough values to unpack (expected 4, got 3)

This is because get_site_root_paths now expects a 4th value with the language:

https://github.com/wagtail/wagtail/blob/be45cee2aa245debe36630813df43867592340e1/wagtail/core/models.py#L287

So _localized_site_get_site_root_paths needs to be updated accordingly.

(site.id, site.root_page.url_path, site.root_url)

Any ETA when 2.11 compatibility will be released on PyPi?