Add code space to Tx sync and async `Response`
Closed this issue · 0 comments
ljoss17 commented
Description
Sync and async transaction broadcast request errors have a code to identify the cause of the error, but these errors can originated from different sources such as Cosmos SDK, https://github.com/cosmos/cosmos-sdk/blob/main/types/errors/errors.go, or ibc-go channel module, https://github.com/cosmos/ibc-go/blob/main/modules/core/04-channel/types/errors.go.
The code alone might not have enough information as the sources sometimes use the same codes. For example insufficient fee from Cosmos SDK and invalid packet from ibc-go channel module both have the error code 13:
- https://github.com/cosmos/cosmos-sdk/blob/main/types/errors/errors.go#L47
- https://github.com/cosmos/ibc-go/blob/main/modules/core/04-channel/types/errors.go#L20
Definition of "done"
Adding the codespace to the Response would fix this issue.