ingadhoc/odoo-argentina

Missing dependencies and respective versions.

Closed this issue · 5 comments

You could add a requirements.txt with the version for the needed pypi packages.

After some very little testing I've found that BeautifulSoup (any version apparently) and geopy (<=0.94)

The geopy change is just a name change from Google to GoogleV3 (very pointless in my opinion but the python will throw an undefined exception) probably later I'll make a pull request with the change

Great idea, would be great if you can collaborate with a PR.
In this instructions you can see the versions we use for pypi packages
http://odooargentina.com/page/instalar-usando-virtualenv

But as you said, would be great to remove/correct some dependencies and yo add requierments. Perhups requirements should be in openerp.py rather than requiermients.txt.

By a requirements.txt I mean a list of dependecies for pip install -r requirements.txt. I'm kind of new to odoo/openerp but openerp.py is for the openerp modules on which the module depends not a list of pypi dependencies, right?

Personally I prefer a requirements.txt to use with pip because it's what I use to install all of my python dependencies (especially in my docker stuff) if you want the requirements.txt probably tomorrow I'll make the pull request otherwise it'll be only in my docker stuff to install the localization-argentina module

BTW to write openerp.py correctly you have to escape the _ with \s like this: \_\_openerp\_\_.py our just quote it with ``

And finally thanks for replying so fast.

Great, thanks for the tip! New in github!
In __openerp__.py you can defiine module dependencies and also something like
"external_dependencies": {
'python': ['ldap'],
},
I'm not sure if odoo is installing this automatically but at least use it for documentation and for raising an exception.
I understand why requeriments.txt helps, specially making a build on docker. So, perhups, both places would be the right choise, not sure.
Thanks you for your interest! Please look forward to collaborate and join us any way.

One final question: Is this module self contained or does it need other modules to work? Because many dependencies in the page you gave are not for this module but for some of the other modules that you also install.

I didn't know about the external_dependencies. Interesting.

EDIT: With this I'm asking if I should add all the dependencies or just the one that this module actually needs

Sorry, I didn't understand the final question :)
Which module? "ingadhoc/odoo-argentina" modules need other modules like "report_extended" (ingadhoc/odoo-addons) and "report_aeroo" for example.