inishchith/chaoss-microtasks

Suggesttions / Improvements

Closed this issue · 11 comments

inishchith commented
  • This Section is for improvements and suggestions over the microtasks performed.
valeriocos commented

Thank you @inishchith for sharing the repo. I had a look to your microtasks and overall they look great.
If you agree, I would open an issue per microtask, so all comments/feedback for a given microtask will be isolated from the other ones.

I read that you have already worked with scancode (https://github.com/inishchith/chaoss-microtasks/tree/master/microtask-9#--optional-). That's indeed a good news, could you tell me what you did with scancode ?

Thank you!

inishchith commented

If you agree, I would open an issue per microtask, so all comments/feedback for a given microtask will be isolated from the other ones.

Sure. I've opened Microtask #*. Issues. We can have discussion over there ;)

I read that you have already worked with scancode (https://github.com/inishchith/chaoss-microtasks/tree/master/microtask-9#--optional-). That's indeed a good news, could you tell me what you did with scancode ?

Thanks. I have worked on couple of problems and documentation work.

  1. Limit number of urls and emails reported in a single file #384 Merged
  • The problem was related to number of emails reported from the licenses. Sometimes this number used to be too large hence after some suggestions I worked on adding an option in order to restrict the number of emails reported per file solving this issue. Then there used to be intense work to be done on the plugin-architecture as you can see on the issue thread.
  1. Add STMicroelectronics license Merged
  • Here i worked on adding a STMicroelectronics license ( Permissive Free License ) to the existing set of available licenses.
  1. Adopt a code of conduct #301 Open
  • 👍1
valeriocos commented

Thank you for the info!

inishchith commented

@valeriocos Thanks for the feedback on the issue tickets, I'll have a look one by one and resolve them ;)

  • 👍1
inishchith commented

@valeriocos I've updated the repository with the suggestions given on each issue ticket. Please do have a look and let me know if you've got some suggestions . Thanks :)

valeriocos commented

Perfect @inishchith , I'll have a look at it today, thanks

  • 👍1
valeriocos commented

Hi @inishchith I have just had a look to your repo. Everything looks OK, I left just a minor comment for microtask-3 #4

Thank you for your work

  • 👍1
inishchith commented

@valeriocos Thanks for the review. I've updated the repository after having a look at your comments at #4 . :)

valeriocos commented

you're welcome @inishchith :)

  • 👍1
inishchith commented

@valeriocos I had closed some of the issues, thought they were resolved after your suggestions. Do let me know if that's okay.

valeriocos commented

They look ok, thanks for addressing my comments @inishchith

  • 👍1