init64/octoffers

Implement Optional Postgres Database Support

webgtx opened this issue · 5 comments

webgtx commented

Description:
Currently, octoffers uses SQLite as its database. We should add an optional feature to allow users to use Postgres instead.

Expected Behavior:
Users should be able to configure octoffers to use either SQLite or Postgres.

spline2hg commented

I am planning on adding optional PostgreSQL support to the current db/schema in djinni.py by integrating psycopg2. Users will be able to configure the database using environment variables to switch between SQLite (default) and PostgreSQL. does this seems right?

webgtx commented

@spline2hg Hi, sorry for the late response.

psycopg2 is a decent choice. regarding implementation, I think we need to create one generic scheme where we can use on all platforms, like octoffers.platforms.driver. So we don't have to repeat ourselves

  • 👍1
sanjeevtripurari commented

is this issue picked?

spline2hg commented

is this issue picked?

yep, i am working on it

  • 👍1
webgtx commented

is this issue picked?

I just want to clarify that I assign anyone who's willing to work on the issue, and whoever gets their pull request approved first claims the issue.

  • 👍1
  • 🎉1