innolitics/hdat

Improve missing method error messages

Opened this issue · 0 comments

I forgot that we had changed Suite.verify to Verify.check.

When I ran an hdat case I saw:

Traceback (most recent call last):
  File "/Users/johndavidgiese/.pyenv/versions/3.6.3/envs/lib/python3.6/site-packages/hdat/runner.py", line 27, in run_cases
    status, comments = run_case(suite, golden_store, archive, git_info, case_id)
  File "/Users/johndavidgiese/.pyenv/versions/3.6.3/envs/lib/python3.6/site-packages/hdat/runner.py", line 50, in run_case
    passed, comments = suite.check(golden_result['metrics'], metrics)
  File "/Users/johndavidgiese/.pyenv/versions/3.6.3/envs/lib/python3.6/site-packages/hdat/suite.py", line 30, in check
    raise NotImplementedError()
NotImplementedError

It would be nice if the error messages were more helpful if there is a missing method like this. E.g. new users may not fully understand what all of the methods are for.