input-output-hk/typed-protocols

[typed-protocols]: Fix the contra-tracer mess

erikd opened this issue · 4 comments

coot commented

Fixed in #37, isn't it? If not, please reopen.

erikd commented

@coot This will actually have to be reverted. This PR fixed it in this package but the overall problem is much bigger and hairier.

Renaming IOG's contra-tracer to iog-contra-tracer and propagating this through all the repos is incredibly difficult.
The problems include:

  • contra-tracer is used everywhere.
  • The Hackage version and the IOG version have the same package name, define the same module names but are not 100% compatible.
  • Some code in ouroboros-network is designed to be compatible with both the Hackage of the IOG version.
  • node uses a non-head version of ouroboros-network that includes ouroboros-consensus.
  • Current HEAD of ouroboros-network does not include ouroboros-consensus.
  • If any repo is upgraded to use iog-contra-tracer and any of the packages in that repo or ANY of its dependencies still relies on contra-tracer cabal with pull in the Hackage version instead of the IOG version and the compile will break.

I tried 3 different ways to fix this and all failed due to one or more of the above.

  • 👍1
erikd commented

PR is #39

erikd commented

Done!

  • 👍1