withMenuContext is not declared in index.d.ts

Question

withMenuContext is not declared in index.d.ts

nitzanbueno opened this issue 4 years ago · 5 comments

I'm on version 0.15.7 and the function withMenuContext works fine, but is not declared in index.d.ts, and thus causes a compilation error when imported.

Answer 1 · 2020-06-22T13:55:27.000Z

hi there, are you willing to contribute the fix?

Answer 2 · 2020-06-22T18:00:08.000Z

I'll try my best.

Answer 3 · 2020-06-26T20:42:46.000Z

I wasn't sure if I should add types for the MenuRegistry object, so I did.
If you need me to, I can remove them

Answer 4 · 2020-07-04T12:25:44.000Z

Could you merge the PR?

Answer 5 · 2020-07-04T15:34:03.000Z

thanks for your help, merged