instea/react-native-popup-menu

Typescript types issues

hardik-javascript opened this issue ยท 0 comments

Hi! ๐Ÿ‘‹

Firstly, thanks for your work on this project! ๐Ÿ™‚

Today I used patch-package to patch react-native-popup-menu@0.15.12 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-popup-menu/src/index.d.ts b/node_modules/react-native-popup-menu/src/index.d.ts
index 0ccea4a..730fafd 100644
--- a/node_modules/react-native-popup-menu/src/index.d.ts
+++ b/node_modules/react-native-popup-menu/src/index.d.ts
@@ -20,6 +20,7 @@ declare module "react-native-popup-menu" {
     };
     backHandler?: boolean | Function;
     skipInstanceCheck?: boolean;
+    children: React.ReactNode;
   }
 
   interface MenuProviderStatic extends React.ComponentClass<MenuProviderProps> {
@@ -51,6 +52,7 @@ declare module "react-native-popup-menu" {
     onClose?(): void;
 
     onBackdropPress?(): void;
+    children?: React.ReactNode;
   }
 
   export class Menu extends React.Component<MenuProps> {
@@ -66,6 +68,7 @@ declare module "react-native-popup-menu" {
 
     /** Opens this menu. */
     open(): Promise<void>;
+	
   }
 
   /**
@@ -87,6 +90,8 @@ declare module "react-native-popup-menu" {
 
     onPress?(): void;
     onAlternativeAction? (): void;
+    children?: React.ReactNode;
+    style?: StyleProp<ViewStyle>
   }
 
   export const MenuTrigger: React.ComponentClass<MenuTriggerProps>;
@@ -100,6 +105,7 @@ declare module "react-native-popup-menu" {
     renderOptionsContainer?: Function;
     customStyles?: MenuOptionsCustomStyle;
     testID?: string;
+    children?: React.ReactNode;
   }
 
   interface MenuOptionsCustomStyle extends MenuOptionCustomStyle {
@@ -123,6 +129,7 @@ declare module "react-native-popup-menu" {
     style?: StyleProp<ViewStyle>;
 
     onSelect?(): any;
+    children?: React.ReactNode;
   }
 
   interface MenuOptionCustomStyle {

This issue body was partially generated by patch-package.